It is highly unlikely that he photos were taken in frontline trenches, I suspect that they were taken in training grounds on rear trenches, the colour photo process was not point and click like it is now, and the cost of the equipment was very high, so it is unlikely that it would have been taken to the front, and that would explain the neatness of the trenches.
Best
Gus